Comments on: Close All Forms in an Application in a Thread-Safe Manner http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/ C# Development Fri, 03 Feb 2012 11:14:43 +0000 hourly 1 http://wordpress.org/?v=3.2.1 By: TamusJRoyce http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-939 TamusJRoyce Mon, 03 Oct 2011 14:30:12 +0000 http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-939 List forms = new List(Application.Forms) for (int index = 0; index < forms.count; ++index) { if !(forms(index) is me) { forms(index).Dispose() } // End if } // End for Try this once more. It was parsing my comment like html. List forms = new List(Application.Forms)

for (int index = 0; index < forms.count; ++index)
{
if !(forms(index) is me)
{
forms(index).Dispose()
} // End if
} // End for

Try this once more. It was parsing my comment like html.

]]> By: TamusJRoyce http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-938 TamusJRoyce Mon, 03 Oct 2011 14:27:55 +0000 http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-938 List forms = new List(Application.Forms) Sorry. In dumb vb mindset at the moment ;) List forms = new List(Application.Forms)

Sorry. In dumb vb mindset at the moment ;)

]]> By: TamusJRoyce http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-937 TamusJRoyce Mon, 03 Oct 2011 14:26:21 +0000 http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-937 List forms = new List(Application.Forms) for (int index = 0; index < forms.count; ++index) { if !(forms(index) is me) { forms(index).Dispose() } // End if } // End for I think this is much simpler than using an array. Little more expensive. But many times more manageable. I agree with using .Dispose() over .Close(). I'm not sure if it invokes the same events as .Close() does. Which means Form.Closing/form.Closed might not run? Just depends if you are handing those events or not (or they may still run, untested). List forms = new List(Application.Forms)

for (int index = 0; index < forms.count; ++index)
{
if !(forms(index) is me)
{
forms(index).Dispose()
} // End if
} // End for

I think this is much simpler than using an array. Little more expensive. But many times more manageable.

I agree with using .Dispose() over .Close(). I'm not sure if it invokes the same events as .Close() does. Which means Form.Closing/form.Closed might not run? Just depends if you are handing those events or not (or they may still run, untested).

]]> By: G http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-936 G Fri, 19 Aug 2011 09:38:59 +0000 http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-936 I ended up using .Dispose() instead of .Close() and this seemeed to get ride of the Dialog box infront of my Form. By the way I wanted to close all open forms except my main form. This is when the issue occured. I ended up using .Dispose() instead of .Close() and this seemeed to get ride of the Dialog box infront of my Form.
By the way I wanted to close all open forms except my main form. This is when the issue occured.

]]> By: G http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-935 G Thu, 18 Aug 2011 12:51:01 +0000 http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-935 I am having a issue where I cannot close a Form that has a dialog error message box on top of a form. When I try using the .Close() method on the form it also does not close the form because it still has a open dialog on top of it. So when I do a (Application.OpenForms) it does not show the message box form as part of the count. Think it relates to Kirill question: 'how about close dialog boxes? opened by the forms? :)' I am having a issue where I cannot close a Form that has a dialog error message box on top of a form.

When I try using the .Close() method on the form it also does not close the form because it still has a open dialog on top of it.

So when I do a (Application.OpenForms) it does not show the message box form as part of the count.

Think it relates to Kirill question:

‘how about close dialog boxes? opened by the forms? :) ’

]]> By: Vignesh http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-934 Vignesh Fri, 10 Jun 2011 18:12:12 +0000 http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-934 This thread helped me.. thanks a lot.. This thread helped me.. thanks a lot..

]]> By: manju http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-933 manju Fri, 03 Jun 2011 06:20:25 +0000 http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-933 Its working fine Its working fine

]]> By: Kirill http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-932 Kirill Wed, 01 Jun 2011 08:56:30 +0000 http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-932 how about close dialog boxes? opened by the forms? :) how about close dialog boxes? opened by the forms? :)

]]> By: jainlal http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-931 jainlal Sat, 30 Apr 2011 06:15:30 +0000 http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-931 It is working nice. great!... It is working nice. great!…

]]> By: Jon http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-930 Jon Wed, 13 Oct 2010 14:29:34 +0000 http://www.csharp411.com/close-all-forms-in-a-thread-safe-manner/#comment-930 Ryan's change looks more promising, although I'm not sure what exactly happens when creating a FormCollection (does it simply make a reference to Application.OpenForms or does it copy it? And does the operation behind that copy also have the same problem?) The static OpenForms function runs based on a foreach loop of Application.OpenForms itself, which can be changed via other means during its cycle. You're creating a second array, which is good, but the process used to create the second list is also vulnerable to a form closing during its execution. My situation is different from just doing a window cleanup, though. I'm using it in threads to check and see if program was closed so the threads don't cause it to hang. They check often so once in a great while my program runs into this exception. Ryan’s change looks more promising, although I’m not sure what exactly happens when creating a FormCollection (does it simply make a reference to Application.OpenForms or does it copy it? And does the operation behind that copy also have the same problem?)

The static OpenForms function runs based on a foreach loop of Application.OpenForms itself, which can be changed via other means during its cycle. You’re creating a second array, which is good, but the process used to create the second list is also vulnerable to a form closing during its execution.

My situation is different from just doing a window cleanup, though. I’m using it in threads to check and see if program was closed so the threads don’t cause it to hang. They check often so once in a great while my program runs into this exception.

]]>